Skip to content

chore(pinact): pin/update GitHub Actions - #1035

Open
davidliu wants to merge 1 commit into
mainfrom
ci/pinact_action
Open

chore(pinact): pin/update GitHub Actions#1035
davidliu wants to merge 1 commit into
mainfrom
ci/pinact_action

Conversation

@davidliu

@davidliu davidliu commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Automated update by pinact.

@changeset-bot

changeset-bot Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b8efc8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Oct 5, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@davidliu
davidliu force-pushed the ci/pinact_action branch 2 times, most recently from 8004dd7 to 65f462b Compare October 19, 2026 00:24
@github-actions

github-actions Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: diffuse-source-file
NEW: livekit-android-sdk-release.aar

 AAR      │ old      │ new      │ diff 
──────────┼──────────┼──────────┼──────
      jar │    3 MiB │    3 MiB │  0 B 
 manifest │  1.5 KiB │  1.5 KiB │  0 B 
 lint-jar │ 12.7 KiB │ 12.7 KiB │  0 B 
    other │  2.4 KiB │  2.4 KiB │  0 B 
──────────┼──────────┼──────────┼──────
    total │    3 MiB │    3 MiB │  0 B 

 JAR     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
 classes │  1706 │  1706 │ 0 (+0 -0) 
 methods │ 21984 │ 21984 │ 0 (+0 -0) 
  fields │  5705 │  5705 │ 0 (+0 -0)
AAR 
 size │ diff │ path    
──────┼──────┼─────────
  0 B │  0 B │ (total)

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Oct 26, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Devin Review

Comment thread .github/workflows/android.yml
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
java-version: '17'
distribution: 'adopt'

@devin-ai-integration devin-ai-integration Bot Oct 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Unsupported Java distribution blocks builds and releases

Each Java setup step passes adopt to actions/setup-java v6, which no longer supports that distribution. Setup fails before the CI, dependency-diff, and publishing jobs reach Gradle.

Learn more

actions/setup-java v6 removed the adopt distribution alias. Its distribution factory returns no installer for that value, so each affected setup step fails before any later Gradle command runs. The same value appears in both Java setup steps in the Android workflow and in the changesets, dependency-diff, and manual-release workflows.

Example: A pull request starts the Android CI build job. The Java setup step requests adopt, fails to find a supported distribution, and never runs the SDK tests.

Recommended fix: Set distribution: 'temurin' at all five Java setup steps, keeping the pinned v6 action.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@MaxHeimbrock MaxHeimbrock Awaiting requested review from MaxHeimbrock MaxHeimbrock is a code owner
@xianshijing-lk xianshijing-lk Awaiting requested review from xianshijing-lk xianshijing-lk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidliu